linux-kernel - Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53ABD51C.5050806@gmail.com>
Date:	Thu, 26 Jun 2014 10:09:00 +0200
From:	Jack Wang <xjtuwjp@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Anand Kumar Santhanam <AnandKumar.Santhanam@...s.com>
CC:	lindar_liu@...sh.com,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: pm8001: pm80xx_hwi.c:  Cleaning up variable is
 set more than once

Thanks Rickard,

>From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).

Anand, could you share your opinion?

Regards,
Jack

On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in between.
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index d70587f..2698227 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -249,7 +249,6 @@ moreData:
>  				sprintf(pm8001_ha->
>  					forensic_info.data_buf.direct_data,
>  						"%08x ", 4);
> -			pm8001_ha->forensic_info.data_buf.read_len = 0xFFFFFFFF;
>  			pm8001_ha->forensic_info.data_buf.direct_len =  0;
>  			pm8001_ha->forensic_info.data_buf.direct_offset = 0;
>  			pm8001_ha->forensic_info.data_buf.read_len = 0;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/