lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jun 2014 11:03:59 +0200 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Javier Martinez Canillas <javier.martinez@...labora.co.uk> Cc: Lee Jones <lee.jones@...aro.org>, Samuel Ortiz <sameo@...ux.intel.com>, Mark Brown <broonie@...nel.org>, Mike Turquette <mturquette@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, Alessandro Zummo <a.zummo@...ertech.it>, Kukjin Kim <kgene.kim@...sung.com>, Doug Anderson <dianders@...omium.org>, Olof Johansson <olof@...om.net>, Sjoerd Simons <sjoerd.simons@...labora.co.uk>, Daniel Stone <daniels@...labora.com>, Tomeu Vizoso <tomeu.vizoso@...labora.com>, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote: > From: Doug Anderson <dianders@...omium.org> > > The max77686 includes an RTC that keeps power during suspend. It's > convenient to be able to use it as a wakeup source. > > NOTE: due to wakeup ordering problems this patch alone doesn't work so > well on exynos5250-snow. You also need something that brings the i2c > bus up before the max77686 wakeup runs. > > Signed-off-by: Doug Anderson <dianders@...omium.org> > Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk> > --- > > Changes since v3: > - Keep the note that this patch needs another change due wakeup > ordering problems. > > drivers/rtc/rtc-max77686.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> Best regards, Krzysztof > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index d20a7f0..c1c6055 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -583,6 +583,33 @@ static void max77686_rtc_shutdown(struct platform_device *pdev) > #endif /* MAX77686_RTC_WTSR_SMPL */ > } > > +#ifdef CONFIG_PM_SLEEP > +static int max77686_rtc_suspend(struct device *dev) > +{ > + if (device_may_wakeup(dev)) { > + struct max77686_rtc_info *info = dev_get_drvdata(dev); > + > + return enable_irq_wake(info->virq); > + } > + > + return 0; > +} > + > +static int max77686_rtc_resume(struct device *dev) > +{ > + if (device_may_wakeup(dev)) { > + struct max77686_rtc_info *info = dev_get_drvdata(dev); > + > + return disable_irq_wake(info->virq); > + } > + > + return 0; > +} > +#endif > + > +static SIMPLE_DEV_PM_OPS(max77686_rtc_pm_ops, > + max77686_rtc_suspend, max77686_rtc_resume); > + > static const struct platform_device_id rtc_id[] = { > { "max77686-rtc", 0 }, > {}, > @@ -592,6 +619,7 @@ static struct platform_driver max77686_rtc_driver = { > .driver = { > .name = "max77686-rtc", > .owner = THIS_MODULE, > + .pm = &max77686_rtc_pm_ops, > }, > .probe = max77686_rtc_probe, > .shutdown = max77686_rtc_shutdown, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists