linux-kernel - Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1403785075.7977.46.camel@joe-AO725>
Date:	Thu, 26 Jun 2014 05:17:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	Maurizio Lombardi <mlombard@...hat.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Eddie Wai <eddie.wai@...adcom.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c:  Cleaning up variable is
 set more than once

On Thu, 2014-06-26 at 14:12 +0200, Maurizio Lombardi wrote:
> 
> On 06/26/2014 02:05 PM, Joe Perches wrote:
> > On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
> >> A struct member variable is set to different values without having used in between.
> > []
> >> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > []
> >> @@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> >>  	stats->r2t_pdus = conn->r2t_pdus_cnt;
> >>  	stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
> >>  	stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
> >> -	stats->custom_length = 3;
> >>  	strcpy(stats->custom[2].desc, "eh_abort_cnt");
> >>  	stats->custom[2].value = conn->eh_abort_cnt;
> >>  	stats->digest_err = 0;
> >>  	stats->timeout_err = 0;
> >> -	stats->custom_length = 0;
> >> +	stats->custom_length = 3;
> > 
> > You are changing custom_length from 0 to 3.
> > 
> > Why is this correct?
> 
> http://marc.info/?l=linux-scsi&m=140371670511706&w=2

Then the subject and commit message are wrong and need
to be updated to reflect your text.

This is a bugfix, not a cleanup.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/