linux-kernel - Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2014 10:51:11 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Luiz Capitulino <lcapitulino@...hat.com>, linux-mm@...ck.org
CC:	linux-kernel@...r.kernel.org, isimatu.yasuaki@...fujitsu.com,
	yinghai@...nel.org, andi@...stfloor.org, akpm@...ux-foundation.org,
	rientjes@...gle.com
Subject: Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename
 function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/19/2014 10:20 PM, Luiz Capitulino wrote:

> @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct
> numa_meminfo *mi) end = max(mi->blk[i].end, end); }
> 
> -		if (start < end) -			setup_node_data(nid, start, end); +		if
> (start >= end) +			continue; + +		/* +		 * Don't confuse VM with a
> node that doesn't have the +		 * minimum amount of memory: +		 */ +
> if (end && (end - start) < NODE_MIN_SIZE) +			continue; + +
> alloc_node_data(nid); }

Minor nit.  If we skip a too-small node, should we remember that we
did so, and add its memory to another node, assuming it is physically
contiguous memory?

Other than that...

Acked-by: Rik van Riel <riel@...hat.com>

- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTrDNfAAoJEM553pKExN6DrNgH/j160OIey5moCEFMH51a1e3+
D6iOIXxsVii5/wqabYuA1DCQ8Asgd/UK2BWdxxRZVZuTHXXn97iifq1IkIPEQxXc
pjz25/ZFSpa3fgZk8iyUzOQjLukFfkiaO1mSopO7IWwUZoEa9fJ7bOBvwcnFU4oQ
uZAV375RpxiPEXNh2qQZXX0kNrycZd8S81jUSuQv3OLPRI1EQo+txOg/u7ir0pOJ
z1fkBK0hiSHziAzB/nyjR/RgSb23vpMlUlPoGMhwCMp08aJkL147bHZvsCtlg/w4
kBqq/zy9te4ecSicUsX/l16o0SJ9a1JtvFAlqz0iqlGcKQGCEw2P+y0ZyrhfvaE=
=NOgK
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/