linux-kernel - Re: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140626163707.GA26836@arch.cereza>
Date:	Thu, 26 Jun 2014 13:37:07 -0300
From:	Ezequiel García <ezequiel@...guardiasur.com.ar>
To:	Guido Martínez <guido@...guardiasur.com.ar>
Cc:	Tony Lindgren <tony@...mide.com>, pekon@...com,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

On 26 Jun 12:02 PM, Guido Martínez wrote:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
> 
> This patch changes the iteration to only probe nodes marked as
> available.
> 
> Signed-off-by: Guido Martínez <guido@...guardiasur.com.ar>

Just a nit: the commit title doesn't match the recent commits. If you
run "git log" on this file, you'll find the pattern should be something
like:

"ARM: OMAP2+: GPMC should only probe enabled devices"

Other than this, the patch looks correct.

Thanks,
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/