linux-kernel - Re: [PATCH] RFC: Add signal command to trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140626164516.GA24731@redhat.com>
Date:	Thu, 26 Jun 2014 18:45:16 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Christopher Covington <cov@...eaurora.org>,
	Ingo Molnar <mingo@...hat.com>,
	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Vagin <avagin@...nvz.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RFC: Add signal command to trace events

On 06/26, Oleg Nesterov wrote:
>
> > > +//ifdef CONFIG_TRACER_SIGNAL
> > > +static void
> > > +signal_trigger(struct event_trigger_data *data)
> > > +{
> > > +	force_sig(SIGSTOP, current);
>
> Well, I don't like this. Imho, it would be nice to avoid signals here.
>
> And SIGSTOP in particular. It can interfere with the "real" SIGSTOP
> sent by user, with ptrace, with tty.

And I forgot to mention, note that SIGSTOP stops the whole thread group,
this is not what we want.

> I think we need something else... "STOP" is actually simple, but we need
> some interface which allows to wakeup a task sleeping in TASK_KILLABLE
> after it hits ETT_FREEZE.

Yes...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/