linux-kernel - Re: [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test before debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2014 13:44:35 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test
 before debugfs_remove

On Thu, 26 Jun 2014 19:14:31 +0200
Fabian Frederick <fabf@...net.be> wrote:

> This fixes checkpatch warning:
> 
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"

Thanks, applied to my 3.17 queue.

-- Steve

> 
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  kernel/trace/trace.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 384ede3..58c78e4 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -6095,10 +6095,8 @@ destroy_trace_option_files(struct trace_option_dentry *topts)
>  	if (!topts)
>  		return;
>  
> -	for (cnt = 0; topts[cnt].opt; cnt++) {
> -		if (topts[cnt].entry)
> -			debugfs_remove(topts[cnt].entry);
> -	}
> +	for (cnt = 0; topts[cnt].opt; cnt++)
> +		debugfs_remove(topts[cnt].entry);
>  
>  	kfree(topts);
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/