linux-kernel - Re: [PATCH 1/1] FS/OMFS: block number sanity check during fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20140626202636.7b601260c02ecc45c3c87316@skynet.be>
Date:	Thu, 26 Jun 2014 20:26:36 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Bob Copeland <me@...copeland.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] FS/OMFS: block number sanity check during
 fill_super operation

On Thu, 26 Jun 2014 10:08:04 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Jun 26, 2014 10:05 AM, "Fabian Frederick" <fabf@...net.be> wrote:
> >
> > +#define OMFS_MAX_BLOCKS (1 << 31)
> 
> This is wrong. Think about the types, and what value this has...
> 

Hello Linus,

   Sorry but I don't see a problem with 2^31 value.
It's being compared to u64 value then used in DIV_ROUND_UP: divided by 8 to fit in unsigned int (maximum 2^32 - 1)... What value should I use ?

Thanks,
Fabian

>      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/