linux-kernel - Re: [RFC PATCH 2/5] kernel/rcu/tree_plugin.h:1494 fix a sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140626193912.GY4603@linux.vnet.ibm.com>
Date:	Thu, 26 Jun 2014 12:39:12 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	linux-kernel@...r.kernel.org, Josh Triplett <josh@...htriplett.org>
Subject: Re: [RFC PATCH 2/5] kernel/rcu/tree_plugin.h:1494 fix a sparse
 warning

On Wed, Jun 11, 2014 at 04:39:40PM -0400, Pranith Kumar wrote:
> kernel/rcu/tree_plugin.h:1494:13: warning: context imbalance in 'rcu_initiate_boost' - unexpected unlock
> 
> by annotating the function with releases()
> 
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>

Hearing no objections, I have queued this for 3.17.

							Thanx, Paul

> ---
>  kernel/rcu/tree_plugin.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index cbc2c45..0c955d9 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1256,6 +1256,7 @@ static int rcu_boost_kthread(void *arg)
>   * about it going away.
>   */
>  static void rcu_initiate_boost(struct rcu_node *rnp, unsigned long flags)
> +	__releases(rnp->lock)
>  {
>  	struct task_struct *t;
> 
> @@ -1491,6 +1492,7 @@ static void rcu_prepare_kthreads(int cpu)
>  #else /* #ifdef CONFIG_RCU_BOOST */
> 
>  static void rcu_initiate_boost(struct rcu_node *rnp, unsigned long flags)
> +	__releases(rnp->lock)
>  {
>  	raw_spin_unlock_irqrestore(&rnp->lock, flags);
>  }
> -- 
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/