linux-kernel - Re: [PATCH v3] arch/score/include/uapi/asm/ptrace.h: Remove the macros which not be used currently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53ACACB6.6000505@gmail.com>
Date:	Fri, 27 Jun 2014 07:28:54 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Lennox Wu <lennox.wu@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Liqin Chen <liqin.linux@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] arch/score/include/uapi/asm/ptrace.h: Remove the macros
 which not be used currently



On 06/27/2014 05:56 AM, David Rientjes wrote:
> On Thu, 26 Jun 2014, Chen Gang wrote:
> 
>> 'COUNTER' and other same kind macros are too common to use, and easy to
>> get conflict with other modules.
>>
>> At present, they are not used, so it is OK to simply remove them. And the
>> related warning (allmodconfig with score):
>>
>>     CC [M]  drivers/md/raid1.o
>>   In file included from drivers/md/raid1.c:42:0:
>>   drivers/md/bitmap.h:93:0: warning: "COUNTER" redefined
>>    #define COUNTER(x) (((bitmap_counter_t) x) & COUNTER_MAX)
>>    ^
>>   In file included from ./arch/score/include/asm/ptrace.h:4:0,
>>                    from include/linux/sched.h:31,
>>                    from include/linux/blkdev.h:4,
>>                    from drivers/md/raid1.c:36:
>>   ./arch/score/include/uapi/asm/ptrace.h:13:0: note: this is the location of the previous definition
>>    #define COUNTER  38
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> 
> Acked-by: David Rientjes <rientjes@...gle.com>
> 

OK, thanks. And also thank all of you for your discussions.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/