linux-kernel - Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AD1368.8020305@st.com>
Date:	Fri, 27 Jun 2014 08:47:04 +0200
From:	Patrice Chotard <patrice.chotard@...com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Maxime Coquelin <maxime.coquelin@...com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <kernel@...inux.com>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: pinctrl-st.c:  Cleaning up values that are never
 used

Hi Rickard

On 06/26/2014 03:44 PM, Rickard Strandqvist wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/pinctrl/pinctrl-st.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..d3bd687 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>   	const __be32 *list;
>   	struct property *pp;
>   	struct st_pinconf *conf;
> -	phandle phandle;
>   	struct device_node *pins;
> -	u32 pin;
>   	int i = 0, npins = 0, nr_props;
>   
>   	pins = of_get_child_by_name(np, "st,pins");
> @@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
>   		conf = &grp->pin_conf[i];
>   
>   		/* bank & offset */
> -		phandle = be32_to_cpup(list++);
> -		pin = be32_to_cpup(list++);
> +		be32_to_cpup(list++);
> +		be32_to_cpup(list++);
>   		conf->pin = of_get_named_gpio(pins, pp->name, 0);
>   		conf->name = pp->name;
>   		grp->pins[i] = conf->pin;

Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/