linux-kernel - RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4656BEB6164FC34F8171C6538F1A595B2E947646@SHSMSX101.ccr.corp.intel.com>
Date:	Fri, 27 Jun 2014 08:20:00 +0000
From:	"Chen, Alvin" <alvin.chen@...el.com>
To:	David Laight <David.Laight@...LAB.COM>,
	'Jingoo Han' <jg1.han@...sung.com>,
	'Alan Stern' <stern@...land.harvard.edu>
CC:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"'Sergei Shtylyov'" <sergei.shtylyov@...entembedded.com>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>
Subject: RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel
 Quark X1000



> -----Original Message-----
> From: David Laight [mailto:David.Laight@...LAB.COM]
> Sent: Friday, June 27, 2014 4:08 PM
> ...
> > /* The maximal threshold value is 0x80, which means 512 bytes */
> > #define EHCI_THRESHOLD_512BYTES		0x80
> > #define EHCI_THRESHOLD_508BYTES		0x79
> 
> It would be better to define these using expressions. So:
> #define EHCI_THRESHOLD_512BYTES		(512u / 8u)
> #define EHCI_THRESHOLD_508BYTES		(508u / 8u)
> 
Just to clarify, the threshold value set to register is in dword, so '0x80' means 0x80 dwords (512 bytes), and 508 bytes is not 0x79, it is 0x7F.

> Then you might decide to use:
> #define EHCI_THRESHOLD(size) ((size) / 8u)
> 
> Then realise that the names are not generic EHCI, so need some driver-specific
> prefix (for namespace reasons).
> 
How about the following?
#define INTEL_QUARK_X1000_EHCI_THRESHOLD(size) ((size) / 4u)  /* threshold value is in dword*/

> And that the defines are probably limit values, and should be named as such.
> 
> 	David
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/