linux-kernel - RE: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CE2C58F938F4C44EA74FFF880BAA7E5E1CD730A3@BBYEXM02.pmc-sierra.internal>
Date:	Fri, 27 Jun 2014 09:06:49 +0000
From:	Suresh Thiagarajan <Suresh.Thiagarajan@...s.com>
To:	Jack Wang <xjtuwjp@...il.com>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC:	"lindar_liu@...sh.com" <lindar_liu@...sh.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: pm8001: pm80xx_hwi.c:  Cleaning up variable is
 set more than once



On Thu, Jun 26, 2014 at 1:50 PM, Maurizio Lombardi <mlombard@...hat.com> wrote:
> On 06/26/2014 10:09 AM, Jack Wang wrote:
>> Thanks Rickard,
>>
>> From my point of view, looks good, but I'd like to get review from Anand
>> (cc-ed).
>
> I would like to add that I noticed that this fields is only set and appears to be never used,
> maybe it could be completely removed.

You are correct. The whole forensic_info structure itself is not used or referred anywhere. I will remove it and send a patch.

Regards,
Suresh Thiagarajan
>
> Regards,
> Maurizio Lombardi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/