linux-kernel - Re: [PATCH 2/2] rsi: fix memory leaks and error handling in rsi_91x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOiHx=npgf-YczNVeiZ25Nh8yGeOVvvzT4Hvt2ocL705wexUYQ@mail.gmail.com>
Date:	Fri, 27 Jun 2014 12:17:37 +0200
From:	Jonas Gorski <jogo@...nwrt.org>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	"John W. Linville" <linville@...driver.com>,
	Fariya Fatima <fariyaf@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	netdev@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	ldv-project@...uxtesting.org
Subject: Re: [PATCH 2/2] rsi: fix memory leaks and error handling in rsi_91x_usb

On Fri, Jun 27, 2014 at 12:51 AM, Alexey Khoroshilov
<khoroshilov@...ras.ru> wrote:
> The patch fixes a couple of issues:
> - absence of deallocation of rsi_dev->rx_usb_urb[0] in the driver;
> - potential NULL pointer dereference because of lack of checks for memory
>   allocation success in rsi_init_usb_interface().
>
> By the way, it makes rsi_probe() returning error code instead of 1
> and fixes comments regarding returning values.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

I count four different issues being fixed, so maybe split this into
four patches?


Regards
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/