linux-kernel - Re: mfd: sec-core requires regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140627101940.GJ19645@lee--X1>
Date:	Fri, 27 Jun 2014 11:19:40 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jim Davis <jim.epost@...il.com>, sfr@...b.auug.org.au,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, sbkim73@...sung.com,
	sameo@...ux.intel.com, grant.likely@...aro.org, robh+dt@...nel.org,
	devicetree <devicetree@...r.kernel.org>
Subject: Re: mfd: sec-core requires regulators

On Fri, 27 Jun 2014, Lee Jones wrote:

> On Tue, 24 Jun 2014, Arnd Bergmann wrote:
> 
> > The newly added sec-core mfd module calls the regulator_suspend_prepare()
> > function, which is only available if the regulator API is provided. This
> > matches the usage of the driver, so we can just add a Kconfig dependency.
> > 
> > Reported-by: Jim Davis <jim.epost@...il.com>
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Thanks for re-sending Arnd, patch applied.

Slight change of plan - this appears to have been fixed by 591123e.

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 207c433..1caa3c5 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -582,7 +582,7 @@ config MFD_RC5T583
> >  
> >  config MFD_SEC_CORE
> >         bool "SAMSUNG Electronics PMIC Series Support"
> > -       depends on I2C=y
> > +       depends on I2C=y && REGULATOR
> >         select MFD_CORE
> >         select REGMAP_I2C
> >         select REGMAP_IRQ
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/