linux-kernel - Re: [PATCH V2 2/2] irqchip: gic: preserve gic V2 bypass bits in cpu ctrl register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2014 07:17:46 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Feng Kan <fkan@....com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Marc Zyngier <marc.zyngier@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	patches <patches@....com>, Vinayak Kale <vkale@....com>
Subject: Re: [PATCH V2 2/2] irqchip: gic: preserve gic V2 bypass bits in
 cpu ctrl register

On Thu, Jun 26, 2014 at 09:48:25AM -0700, Feng Kan wrote:
> On Wed, Jun 25, 2014 at 6:05 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > On Wed, 25 Jun 2014, Feng Kan wrote:
> >
> >> This change is made to preserve the GIC v2 bypass bits in the
> >> GIC_CPU_CTRL register (also known as the GICC_CTLR register in spec).
> >> This code will preserve all bits configured by the bootloader regarding
> >> v2 bypass group bits. In the X-Gene platform, the bypass functionality
> >> is not used and bypass bits should not be changed by the kernel gic
> >> code as it could lead to incorrect behavior.
> >>
> >> Signed-off-by: Vinayak Kale <vkale@....com>
> >> Signed-off-by: Feng Kan <fkan@....com>
> >
> > Who wrote the patch? According to the SOB chain it's Vinayak, but your
> > patch is missing the:
> 
> I wrote the patch which was based on Vinayak's original change. I can
> change it to
> Reviewed-by. I was trying to give him credit.
> 

Then please leave the S-o-b's alone and append a note describing the
changes you made to his original patch.

eg:

----->8-------------
From: Vinayak Kale <vkale@....com>

This change is made to preserve the GIC v2 bypass bits in the
GIC_CPU_CTRL register (also known as the GICC_CTLR register in spec).
This code will preserve all bits configured by the bootloader regarding
v2 bypass group bits. In the X-Gene platform, the bypass functionality
is not used and bypass bits should not be changed by the kernel gic
code as it could lead to incorrect behavior.

[Feng Kan: Rebased on magic number removal patch, added feature X, fixed
bug Y.]

Signed-off-by: Vinayak Kale <vkale@....com>
Signed-off-by: Feng Kan <fkan@....com>
----->8-------------

'git am' will use the info from the last 'From:' as the author of the
commit.

It goes without saying (even though I'm mentioning it ;-) ) the S-o-b
means a very specific thing.  It is *not* there to enhance credit.  It
is there to indicate that the person referenced (yourself and Vinayak)
have read, understood, and consent to the Developer's Certificate of
Origin [1].  Nothing else.

The commit message tags have one purpose:  To accurately render
information about a commit.  Who wrote it, who applied it, who reviewed
it, who let it go by a different tree than the default for a subsystem,
etc.

Attempts to (mis)use them as a corporate evaluation metric only leads to
developers trying to game the system.  More importantly, it wastes
maintainers time because now we have to question whether the appended
tags are indeed factual. :(

thx,

Jason.

[1] Documentation/SubmittingPatches, Section 12.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/