linux-kernel - Re: [PATCH 1/1] mm/hwpoison-inject.c: remove unnecessary null test before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140627210512.GA18026@nhori.bos.redhat.com>
Date:	Fri, 27 Jun 2014 17:05:12 -0400
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/1] mm/hwpoison-inject.c: remove unnecessary null test
 before debugfs_remove_recursive

On Fri, Jun 27, 2014 at 10:58:16PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> "WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required"
> 
> Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> Cc: linux-mm@...ck.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Looks good to me, thank you.

Acked-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> ---
>  mm/hwpoison-inject.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 95487c7..329caf5 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -72,8 +72,7 @@ DEFINE_SIMPLE_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>  
>  static void pfn_inject_exit(void)
>  {
> -	if (hwpoison_dir)
> -		debugfs_remove_recursive(hwpoison_dir);
> +	debugfs_remove_recursive(hwpoison_dir);
>  }
>  
>  static int pfn_inject_init(void)
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/