linux-kernel - Re: [PATCH linux-next] staging: emxx_udc: replace strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 28 Jun 2014 10:09:35 -0700
From:	Joe Perches <joe@...ches.com>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	linux-next@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Magnus Damm <damm+renesas@...nsource.se>
Subject: Re: [PATCH linux-next] staging: emxx_udc: replace strict_strtol call

On Sat, 2014-06-28 at 19:00 +0200, Vincent Stehlé wrote:
> Commit 582e9d37a9a3 'include/linux: remove strict_strto* definitions' has
> obsoleted the strict_strtol function. Use kstrtol instead.
[]
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
[]
> @@ -3285,7 +3285,7 @@ static void __init nbu2ss_drv_set_ep_info(
>  
>  		tempbuf[0] = name[2];
>  		tempbuf[1] = '\0';
> -		res = strict_strtol(tempbuf, 16, &num);
> +		res = kstrtol(tempbuf, 16, &num);


The whole block if code is obtuse and should be simplified to:
---
 drivers/staging/emxx_udc/emxx_udc.c | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index c92ded8..f41831e 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -3276,24 +3276,10 @@ static void __init nbu2ss_drv_set_ep_info(
 	ep->ep.name = name;
 	ep->ep.ops = &nbu2ss_ep_ops;
 
-	if (isdigit(name[2])) {
-
-		long	num;
-		int	res;
-		char	tempbuf[2];
-
-		tempbuf[0] = name[2];
-		tempbuf[1] = '\0';
-		res = strict_strtol(tempbuf, 16, &num);
-
-		if (num == 0)
-			ep->ep.maxpacket = EP0_PACKETSIZE;
-		else
-			ep->ep.maxpacket = EP_PACKETSIZE;
-
-	} else {
+	if (name[2] == '0')
+		ep->ep.maxpacket = EP0_PACKETSIZE;
+	else
 		ep->ep.maxpacket = EP_PACKETSIZE;
-	}
 
 	list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
 	INIT_LIST_HEAD(&ep->queue);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/