lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 28 Jun 2014 15:53:09 -0400
From:	Sasha Levin <sashal@...nel.org>
To:	Nicholas Krause <xerofoify@...il.com>, rth@...ddle.net
CC:	ink@...assic.park.msu.ru, mattst88@...il.com,
	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FIXME of file toploogy.h for alpha cpus

On 06/28/2014 12:07 AM, Nicholas Krause wrote:
> This patch fixs the FIXME message in the function *cpumask_of_node
> for using this function multiple times and the issue with recaluting
> the cpu node mask when reusing this function.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  arch/alpha/include/asm/topology.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/alpha/include/asm/topology.h b/arch/alpha/include/asm/topology.h
> index 9251e13..d301f66 100644
> --- a/arch/alpha/include/asm/topology.h
> +++ b/arch/alpha/include/asm/topology.h
> @@ -31,6 +31,9 @@ static const struct cpumask *cpumask_of_node(int node)
>  	if (node == -1)
>  		return cpu_all_mask;
>  
> +	else if (node == &node_to_cpumask_map[node])
> +		return &node_to_cpumask_map[node];
> +
>  	cpumask_clear(&node_to_cpumask_map[node]);
>  
>  	for_each_online_cpu(cpu) {
> 

Since this patch doesn't even compile, care to tell us how you tested it?


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists