linux-kernel - lib/argv_split.c : should argv be kfree'ed ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AF3925.7070300@gmx.de>
Date:	Sat, 28 Jun 2014 23:52:37 +0200
From:	Toralf Förster <toralf.foerster@....de>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: lib/argv_split.c : should argv be kfree'ed ?

/me wonders if this patch is needed here :


diff --git a/lib/argv_split.c b/lib/argv_split.c
index e927ed0..7de4cb4 100644
--- a/lib/argv_split.c
+++ b/lib/argv_split.c
@@ -85,6 +85,7 @@ char **argv_split(gfp_t gfp, const char *str, int *argcp)
                        *argv++ = argv_str;
                }
        }
+       kfree (argv);
        *argv = NULL;

        if (argcp)

-- 
Toralf

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/