linux-kernel - [PATCH] sched.h: Remove useless `const' from function return type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1406242149270.23403@eddie.linux-mips.org>
Date:	Sun, 29 Jun 2014 00:18:18 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Vincent Guittot <vincent.guittot@...aro.org>
cc:	Dietmar Eggemann <dietmar.eggemann@....com>,
	Preeti U Murthy <preeti@...ux.vnet.ibm.com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	"David S. Miller" <davem@...emloft.net>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hanjun Guo <hanjun.guo@...aro.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Jason Low <jason.low2@...com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Tony Luck <tony.luck@...el.com>, linux390@...ibm.com,
	linux-ia64@...r.kernel.org, linux-s390@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] sched.h: Remove useless `const' from function return type

This fixes:

cc1: warnings being treated as errors
In file included from include/linux/ptrace.h:5,
                 from arch/mips/kernel/cpu-probe.c:16:
include/linux/sched.h:1002: warning: type qualifiers ignored on function return type
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1

This is a regression introduced with commit 
143e1e28cb40bed836b0a06567208bd7347c9672 [sched: Rework sched_domain 
topology definition].  The warning itself is benign except in places like 
the arch/mips subtree where we use `-Werror' to enforce good coding 
practices.  Apparently the warning is GCC-version specific, some versions 
produce it and some do not.

Signed-off-by: Maciej W. Rozycki <macro@...ux-mips.org>
---
Vincent,

 Did you mean:

typedef int __attribute__((const)) (*sched_domain_flags_f)(void);

by any chance?

  Maciej

linux-sched-domain-flags-type.patch
Index: linux-20140623-swarm64/include/linux/sched.h
===================================================================
--- linux-20140623-swarm64.orig/include/linux/sched.h
+++ linux-20140623-swarm64/include/linux/sched.h
@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t do
 bool cpus_share_cache(int this_cpu, int that_cpu);
 
 typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
 
 #define SDTL_OVERLAP	0x01
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/