linux-kernel - Re: [PATCH v2 2/2] lib.c: skip --param parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANeU7Q=FUTd4XTrQeeFGaSqp7eriZS3egAOqDK--OC-kaWyZuw@mail.gmail.com>
Date:	Sun, 29 Jun 2014 00:19:10 -0700
From:	Christopher Li <sparse@...isli.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Josh Triplett <josh@...htriplett.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Linux-Sparse <linux-sparse@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] lib.c: skip --param parameters

Hi Andy,

On Sat, Jun 28, 2014 at 9:59 AM, Christopher Li <sparse@...isli.org> wrote:
> I think this is problematic.There are three possible input
> from args:
> 1) "--parm", you need to ++next skip to next arg, which is the value for parm.
> 2) "--parm=x",  you don't need to skip to next arg.
> 3) "--parm-with-crap", invalid argument. You don't need to skip next arg.


How about this patch, I modify from your patch.
It fix the problem I mention earlier.

If no objections, I will push the change.

Chris

View attachment "0001-lib.c-skip-param-parameters.patch" of type "text/x-patch" (1705 bytes)