linux-kernel - Re: [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Jun 2014 09:55:56 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org
Subject: Re: [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before
 debugfs_remove

On 06/29/2014 09:24 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: linux-mips@...ux-mips.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

Thanks.

> ---
>   arch/mips/jz4740/clock-debugfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/jz4740/clock-debugfs.c b/arch/mips/jz4740/clock-debugfs.c
> index a8acdef..325422d0 100644
> --- a/arch/mips/jz4740/clock-debugfs.c
> +++ b/arch/mips/jz4740/clock-debugfs.c
> @@ -87,8 +87,7 @@ void jz4740_clock_debugfs_add_clk(struct clk *clk)
>   /* TODO: Locking */
>   void jz4740_clock_debugfs_update_parent(struct clk *clk)
>   {
> -	if (clk->debugfs_parent_entry)
> -		debugfs_remove(clk->debugfs_parent_entry);
> +	debugfs_remove(clk->debugfs_parent_entry);
>
>   	if (clk->parent) {
>   		char parent_path[100];
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/