[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <53AFEE55.7080906@users.sourceforge.net>
Date: Sun, 29 Jun 2014 12:45:41 +0200
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Julia Lawall <julia.lawall@...6.fr>
CC: Coccinelle <cocci@...teme.lip6.fr>, linux-kernel@...r.kernel.org,
Fabian Frederick <fabf@...net.be>
Subject: Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test
before freeing functions?
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html
>> http://marc.info/?l=kernel-janitors&m=139405971927100&w=2
> Regular expressions do not allow taking advantage of the optimizations
> provided by Coccinelle and are not easy for a reader to understand.
I find that the application of regexes is appropriate here.
Would you like to optimise any implementation details from my general
approach?
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html
>> http://marc.info/?l=kernel-janitors&m=139405983727148&w=2
> This is not safe due to the use of when any. You have no guarantee that
> there is not a dereference of input in the matched region, or that the
> value of input is still the argument value at the point of the test.
Do you suggest to make the desired detection of input parameter
validation a bit safer?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists