linux-kernel - Re: [PATCH 1/1] drivers/hid/hid-picolcd_debugfs.c: remove unnecessary NULL test before debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1406300954510.28307@pobox.suse.cz>
Date:	Mon, 30 Jun 2014 09:54:57 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Fabian Frederick <fabf@...net.be>
cc:	linux-kernel@...r.kernel.org, bonbons@...ux-vserver.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/hid/hid-picolcd_debugfs.c: remove unnecessary
 NULL test before debugfs_remove

On Sat, 28 Jun 2014, Fabian Frederick wrote:

> Fix checkpatch warning:
> WARNING: debugfs_remove(NULL) is safe this check is probably not required
> 
> Cc: Jiri Kosina <jkosina@...e.cz>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/hid/hid-picolcd_debugfs.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c
> index 024cdf3..3c13af6 100644
> --- a/drivers/hid/hid-picolcd_debugfs.c
> +++ b/drivers/hid/hid-picolcd_debugfs.c
> @@ -883,16 +883,13 @@ void picolcd_exit_devfs(struct picolcd_data *data)
>  
>  	dent = data->debug_reset;
>  	data->debug_reset = NULL;
> -	if (dent)
> -		debugfs_remove(dent);
> +	debugfs_remove(dent);
>  	dent = data->debug_eeprom;
>  	data->debug_eeprom = NULL;
> -	if (dent)
> -		debugfs_remove(dent);
> +	debugfs_remove(dent);
>  	dent = data->debug_flash;
>  	data->debug_flash = NULL;
> -	if (dent)
> -		debugfs_remove(dent);
> +	debugfs_remove(dent);
>  	mutex_destroy(&data->mutex_flash);
>  }

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/