lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140630094637.GA1055@swordfish>
Date:	Mon, 30 Jun 2014 18:46:37 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Weijie Yang <weijie.yang@...sung.com>,
	Jerome Marchand <jmarchan@...hat.com>,
	Nitin Gupta <ngupta@...are.org>
Subject: Re: [PATCH 1/2] zram: use size_t instead of u16

On (06/30/14 11:54), Minchan Kim wrote:
> Date: Mon, 30 Jun 2014 11:54:38 +0900
> From: Minchan Kim <minchan@...nel.org>
> To: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-kernel@...r.kernel.org, Sergey Senozhatsky
>  <sergey.senozhatsky@...il.com>, Weijie Yang <weijie.yang@...sung.com>,
>  Jerome Marchand <jmarchan@...hat.com>, Nitin Gupta <ngupta@...are.org>,
>  Minchan Kim <minchan@...nel.org>
> Subject: [PATCH 1/2] zram: use size_t instead of u16
> X-Mailer: git-send-email 2.0.0
> 
> Some of arch(ex, hexagon and PowerPC) could use PAGE_SHIFT
> as 16 above. In the case, u16 is is lack of representing
> compressed page's size so use size_t.
> 
> Reported-by: Weijie Yang <weijie.yang@...sung.com>
> Signed-off-by: Minchan Kim <minchan@...nel.org>

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss

> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 089e72cd37be..3233bccd6361 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -337,7 +337,7 @@ static int zram_decompress_page(struct zram *zram, char *mem, u32 index)
>  	unsigned char *cmem;
>  	struct zram_meta *meta = zram->meta;
>  	unsigned long handle;
> -	u16 size;
> +	size_t size;
>  
>  	read_lock(&meta->tb_lock);
>  	handle = meta->table[index].handle;
> -- 
> 2.0.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ