linux-kernel - Re: [PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140629212144.GA12303@kroah.com>
Date:	Sun, 29 Jun 2014 14:21:44 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	devel@...verdev.osuosl.org, shaun@...source.ca, weo@...1.de,
	sachin.kamat@...aro.org, peter.p.waskiewicz.jr@...el.com,
	linux-kernel@...r.kernel.org, himangi774@...il.com,
	fempsci@...il.com
Subject: Re: [PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and
 OS_vtophys()

On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote:
> OS_phystov()/OS_vtophys() are replaced with __va()/__pa().

No, you should use virt_to_phys() and phys_to_virt() instead of these
internal macros which might not be correct for all architectures.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/