linux-kernel - Re: [PATCHv2 7/9] ASoC: omap: rx51: Add some error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140630100238.GD4934@xo-6d-61-c0.localdomain>
Date:	Mon, 30 Jun 2014 12:02:40 +0200
From:	Pavel Machek <pavel@....cz>
To:	Sebastian Reichel <sre@...nel.org>
Cc:	Sebastian Reichel <sre@...g0.de>, Mark Brown <broonie@...nel.org>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Tony Lindgren <tony@...mide.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCHv2 7/9] ASoC: omap: rx51: Add some error messages

Hi!

> Add more error messages making it easier to identify problems.
> 
> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> ---
>  sound/soc/omap/rx51.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)

> +	if (err) {
> +		dev_err(card->dev, "Failed to add GPIOs\n");
> +		return err;
> +	}
>  
>  	return err;
>  }


As you'll return err, anyway, you don't need to do it inside the if()... OTOH it 
does not hurt.

Acked-by: Pavel Machek <pavel@....cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/