linux-kernel - Re: [PATCH 1/1] hid: sensor-hub, fix potential memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1406301322000.28307@pobox.suse.cz>
Date:	Mon, 30 Jun 2014 13:22:05 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Slaby <jslaby@...e.cz>
cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	jirislaby@...il.com,
	srinivas pandruvada <srinivas.pandruvada@...el.com>
Subject: Re: [PATCH 1/1] hid: sensor-hub, fix potential memory leak

On Mon, 30 Jun 2014, Jiri Slaby wrote:

> hsdev is not freed in sensor_hub_probe when kasprintf inside the for
> loop fails. This is because hsdev is not set to platform_data yet (to
> be freed by the code in the err_no_mem label). So free the memory
> explicitly in the 'if' branch, as this is the only place where this is
> (and will) be needed.
> 
> Reported-by: coverity
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: srinivas pandruvada <srinivas.pandruvada@...el.com>
> Cc: Jiri Kosina <jkosina@...e.cz>
> ---
>  drivers/hid/hid-sensor-hub.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index a8d5c8faf8cf..584e17ce80e4 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -632,6 +632,7 @@ static int sensor_hub_probe(struct hid_device *hdev,
>  			if (name == NULL) {
>  				hid_err(hdev, "Failed MFD device name\n");
>  					ret = -ENOMEM;
> +					kfree(hsdev);
>  					goto err_no_mem;
>  			}
>  			sd->hid_sensor_hub_client_devs[

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/