linux-kernel - Re: [PATCH V4 14/16] perf, x86: enable LBR callstack when recording callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140630144516.GJ5714@two.firstfloor.org>
Date:	Mon, 30 Jun 2014 16:45:16 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"Yan, Zheng" <zheng.z.yan@...el.com>
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	mingo@...nel.org, acme@...radead.org, eranian@...gle.com,
	andi@...stfloor.org
Subject: Re: [PATCH V4 14/16] perf, x86: enable LBR callstack when
 recording callchain

On Mon, Jun 30, 2014 at 04:50:51PM +0800, Yan, Zheng wrote:
> If a task specific event wants user space callchain but does not want
> branch stack sampling, enable the LBR call stack facility implicitly.
> The LBR call stack facility can help perf to get user space callchain
> in case of there is no frame pointer.
> 
> Note: this feature only affects how to get user callchain. The kernel
> callchain is always got by frame pointers.

I'm not sure I like this. If frame pointer works the LBR state saving
is not needed. This would basically always turn it on right?

Perhaps turn it on lazily if the frame pointer resolution fails a few
times.

An explicit switch would be still better.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/