linux-kernel - RE: [PATCH] hyperv: remove meaningless pr_err() in vmbus_recvpacket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2014 14:51:32 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Jason Wang <jasowang@...hat.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] hyperv: remove meaningless pr_err() in
 vmbus_recvpacket_raw()



> -----Original Message-----
> From: Jason Wang [mailto:jasowang@...hat.com]
> Sent: Sunday, June 29, 2014 11:15 PM
> To: KY Srinivasan; Haiyang Zhang; devel@...uxdriverproject.org; linux-
> kernel@...r.kernel.org
> Cc: Jason Wang
> Subject: [PATCH] hyperv: remove meaningless pr_err() in
> vmbus_recvpacket_raw()
> 
> All its callers depends on the return value of -ENOBUFS to reallocate a bigger
> buffer and retry the receiving. So there's no need to call
> pr_err() here since it was not a real issue, otherwise syslog will be flooded by
> this false warning.
> 
> Cc: K. Y. Srinivasan <kys@...rosoft.com>
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Thanks Jason.

Signed-off-by:  K. Y. Srinivasan <kys@...rosoft.com>

> ---
>  drivers/hv/channel.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index
> 284cf66..531a593 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -808,12 +808,8 @@ int vmbus_recvpacket_raw(struct vmbus_channel
> *channel, void *buffer,
> 
>  	*buffer_actual_len = packetlen;
> 
> -	if (packetlen > bufferlen) {
> -		pr_err("Buffer too small - needed %d bytes but "
> -			"got space for only %d bytes\n",
> -			packetlen, bufferlen);
> +	if (packetlen > bufferlen)
>  		return -ENOBUFS;
> -	}
> 
>  	*requestid = desc.trans_id;
> 
> --
> 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/