linux-kernel - Re: [PATCH] thermal: Add braces around suspect code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9hhionibftb.fsf@arm.com>
Date:	Mon, 30 Jun 2014 16:03:12 +0100
From:	Punit Agrawal <punit.agrawal@....com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Eduardo Valentin <edubezval@...il.com>,
	Zhang Rui <rui.zhang@...el.com>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH] thermal: Add braces around suspect code

Stephen Boyd <sboyd@...eaurora.org> writes:

> It looks like this code is missing braces, otherwise the if
> statement shouldn't have been indented. Fix it.
>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  drivers/thermal/of-thermal.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 04b1be7fa018..a95ee2889b19 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -712,11 +712,12 @@ thermal_of_build_thermal_zone(struct device_node *np)
>  	}
>  
>  	i = 0;
> -	for_each_child_of_node(child, gchild)
> +	for_each_child_of_node(child, gchild) {
>  		ret = thermal_of_populate_bind_params(gchild, &tz->tbps[i++],
>  						      tz->trips, tz->ntrips);
>  		if (ret)
>  			goto free_tbps;
> +	}
>  
>  finish:
>  	of_node_put(child);

Looks good to me.

Reviewed-by: Punit Agrawal <punit.agrawal@....com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/