linux-kernel - Re: [PATCH v2] platform_get_irq: Revert to platform_get_resource if of_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140630161835.GA14632@roeck-us.net>
Date:	Mon, 30 Jun 2014 09:18:35 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Rob Herring <robh@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	Grant Likely <grant.likely@...aro.org>,
	Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH v2] platform_get_irq: Revert to platform_get_resource if
 of_irq_get fails

On Mon, Jun 23, 2014 at 10:48:33AM -0500, Rob Herring wrote:
> On Tue, Jun 17, 2014 at 5:51 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> > Commits 9ec36ca (of/irq: do irq resolution in platform_get_irq)
> > and ad69674 (of/irq: do irq resolution in platform_get_irq_byname)
> > change the semantics of platform_get_irq and platform_get_irq_byname
> > to always rely on devicetree information if devicetree is enabled
> > and if a devicetree node is attached to the device. The functions
> > now return an error if the devicetree data does not include interrupt
> > information, even if the information is available as platform resource
> > data.
> >
> > This causes mfd client drivers to fail if the interrupt number is
> > passed via platform resources. Therefore, if of_irq_get fails, try
> > platform_get_resource as method of last resort. This restores the
> > original functionality for drivers depending on platform resources
> > to get irq information.
> >
> > Cc: Russell King <linux@....linux.org.uk>
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: Tony Lindgren <tony@...mide.com>
> > Cc: Grant Likely <grant.likely@...aro.org>
> > Cc: Grygorii Strashko <grygorii.strashko@...com>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> Acked-by: Rob Herring <robh@...nel.org>
> 
> Greg should take this for 3.16.
> 
Doesn't seem to go anywhere. Guess it's one more patch I'll have to carry
locally :-(. If anyone has a better idea how to fix the problem, please
let me know.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/