linux-kernel - Re: [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53B19A57.2040200@gmail.com>
Date:	Mon, 30 Jun 2014 10:11:51 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Fabian Frederick <fabf@...net.be>,
	Ralf Baechle <ralf@...ux-mips.org>
CC:	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before
 debugfs_remove_recursive

On 06/29/2014 12:16 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: linux-mips@...ux-mips.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

I haven't tested it, but it seems fine, so...

Acked-by: David Daney <david.daney@...ium.com>

> ---
>   arch/mips/cavium-octeon/oct_ilm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/oct_ilm.c b/arch/mips/cavium-octeon/oct_ilm.c
> index 71b213d..2d68a39 100644
> --- a/arch/mips/cavium-octeon/oct_ilm.c
> +++ b/arch/mips/cavium-octeon/oct_ilm.c
> @@ -194,8 +194,7 @@ err_irq:
>   static __exit void oct_ilm_module_exit(void)
>   {
>   	disable_timer(TIMER_NUM);
> -	if (dir)
> -		debugfs_remove_recursive(dir);
> +	debugfs_remove_recursive(dir);
>   	free_irq(OCTEON_IRQ_TIMER0 + TIMER_NUM, 0);
>   }
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/