linux-kernel - Re: [PATCH] Fixes q40_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871tu6ux2c.fsf@igel.home>
Date:	Mon, 30 Jun 2014 19:27:55 +0200
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	geert@...ux-m68k.org, linux-m68k@...ts.linux-m68k.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixes q40_irq_startup to return -ENXIO

Nicholas Krause <xerofoify@...il.com> writes:

> Fixes q40_irq_startup to return -ENXIO for cases 11-13 in the switch
> statement of this function to handle these failure cases.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  arch/m68k/q40/q40ints.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 513f9bb..9dfa1ea 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -49,7 +49,7 @@ static unsigned int q40_irq_startup(struct irq_data *data)
>  	case 1: case 2: case 8: case 9:
>  	case 11: case 12: case 13:
>  		printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq);
> -		/* FIXME return -ENXIO; */
> +		return -ENXIO;

There must be more to it, given the FIXME.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/