lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 30 Jun 2014 20:02:18 +0200
From:	Paolo Bonzini <>
To:	Bandan Das <>
CC:	Nadav Amit <>,
	Nadav Amit <>,,,,,,
Subject: Re: [PATCH] KVM: x86: Fix lapic.c debug prints

Il 30/06/2014 19:39, Bandan Das ha scritto:
> Paolo Bonzini <> writes:
>> Il 30/06/2014 03:03, Nadav Amit ha scritto:
>>>>>           sipi_vector = apic->sipi_vector;
>>>>> -        pr_debug("vcpu %d received sipi with vector # %x\n",
>>>>> +        apic_debug("vcpu %d received sipi with vector # %x\n",
>>>> Why don't we just use pr_debug all throughout ?
>>> I don't know. I just tried to make it consistent, since it really bugged
>>> me while I was debugging the local-apic.
>>> If you prefer the other way around (which does seem to be better), I can
>>> do the search-and-replace.
>> vcpu number probably could be moved inside apic_debug, at which point
>> apic_debug becomes preferrable.
> I am not sure, I think all that could be achieved with a file private
> debug define can be done with pr_debug which is generic.
> Nadav didn't introduce apic_debug to this file, so I am
> fine either way.

I am applying the patch, anything else can be done on top.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists