linux-kernel - Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140630183406.GT31442@saruman.home>
Date:	Mon, 30 Jun 2014 13:34:06 -0500
From:	Felipe Balbi <balbi@...com>
To:	Antoine Ténart 
	<antoine.tenart@...e-electrons.com>
CC:	Felipe Balbi <balbi@...com>, <sebastian.hesselbarth@...il.com>,
	<alexandre.belloni@...e-electrons.com>,
	<thomas.petazzoni@...e-electrons.com>, <zmxu@...vell.com>,
	<jszhang@...vell.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

On Mon, Jun 30, 2014 at 04:52:11PM +0200, Antoine Ténart wrote:
> Felipe,
> 
> On Fri, Jun 27, 2014 at 06:04:33PM -0500, Felipe Balbi wrote:
> > On Fri, Jun 27, 2014 at 06:05:57PM +0200, Antoine Ténart wrote:
> > > Hi Felipe,
> > > 
> > > On Fri, Jun 27, 2014 at 10:56:22AM -0500, Felipe Balbi wrote:
> > > > On Tue, Jun 24, 2014 at 12:35:14PM +0200, Antoine Ténart wrote:
> > > > > Add the driver driving the Marvell Berlin USB PHY. This allows to
> > > > > initialize the PHY and to use it from the USB driver later.
> > > > > 
> > > > > Signed-off-by: Antoine Ténart <antoine.tenart@...e-electrons.com>
> > > > 
> > > > since this is a brand new driver, it should go to drivers/phy instead.
> > > 
> > > This PHY is used by a ChipIdea USB driver, which uses the provided
> > > common function for ChipIdea. These functions use the usb_phy framework.
> > > That's why this PHY driver is there.
> > 
> > right, but you can add support for the new PHY layer which would help
> > other users convert their PHY drivers to the new PHY framework.
> 
> Adding the support for the new PHY layer in the common CI code is not
> complicated, but these functions also use some parts from usb hcd or usb
> otg which are only usb_phy compatible.
> 
> Shouldn't these parts add the new PHY support first, to avoid ending up
> with a fairly big series, quite long to do and complicated to review?

sure, patches are welcome. :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)