[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140630212334.GA5745@gmail.com>
Date: Mon, 30 Jun 2014 23:23:35 +0200
From: Beniamino Galvani <b.galvani@...il.com>
To: Axel Lin <axel.lin@...ics.com>
Cc: Mark Brown <broonie@...nel.org>,
"Wenyou.Yang" <wenyou.yang@...el.com>,
Liam Girdwood <lgirdwood@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: act8865: Explictly initialize of_node
array
On Mon, Jun 30, 2014 at 03:33:25PM +0800, Axel Lin wrote:
> Silence below build warning:
> CC [M] drivers/regulator/act8865-regulator.o
> drivers/regulator/act8865-regulator.c: In function ‘act8865_pmic_probe’:
> drivers/regulator/act8865-regulator.c:321: warning: ‘of_node’ may be used uninitialized in this function
Hi Axel,
some days ago I submitted a patch series that adds support for other
act88xx chips to the driver and reworks the probe function, also
indirectly fixing the warning about uninitialized of_node:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/265477.html
Beniamino
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> drivers/regulator/act8865-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
> index f07be36..e9fea78 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -276,7 +276,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
> struct act8865_platform_data *pdata = dev_get_platdata(dev);
> struct regulator_config config = { };
> struct act8865 *act8865;
> - struct device_node *of_node[ACT8865_REG_NUM];
> + struct device_node *of_node[ACT8865_REG_NUM] = { };
> int i;
> int ret;
>
> --
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists