linux-kernel - Re: [PATCH 0/3] static keys: fix test/set races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140630183639.0e6161ee@gandalf.local.home>
Date:	Mon, 30 Jun 2014 18:36:39 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jason Baron <jbaron@...mai.com>
Cc:	"andi@...stfloor.org" <andi@...stfloor.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"peterz@...radead.org" <peterz@...radead.org>
Subject: Re: [PATCH 0/3] static keys: fix test/set races

On Mon, 30 Jun 2014 17:43:50 -0400
Jason Baron <jbaron@...mai.com> wrote:

> Hi Steve,
> 
> I took a closer look at this, and I'm thinking now that its simpler to
> just take the &inode->i_mutex in sched_feat_write(), surrounding the
> test/set jump_label call. It should be about 3 lines :)

Smaller patches are always nice.

> 
> I started re-working this with the patches in this series and it just
> seemed like a lot of code for only 1 current use-case. (The udp case
> doesn't appear to disable the branch and thus is not racy.)
> 
> So I've swung back to what Ingo originally said - I can test/post the
> suggested 3-line patch, unless there are other thoughts...

Well, the final decision lies with Peter and Ingo. I only noticed it
while cleaning out my inbox and didn't want it to be forgotten.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/