linux-kernel - [PATCH next-20140627] drivers/staging/media/solo6x10: sparse warning corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2014 09:45:04 +0300
From:	Sami Laine <laine.j.sami@...il.com>
To:	ismael.luceno@...p.bluecherry.net
Cc:	m.chehab@...sung.com, gregkh@...uxfoundation.org,
	linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: [PATCH next-20140627] drivers/staging/media/solo6x10: sparse warning
 corrections

From: Sami Laine <laine.j.sami@...il.com>

Sparse warning correction:
  CHECK   drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c
drivers/staging/media/solo6x10/solo6x10-jpeg.h:113:21: warning: symbol 'jpeg_dqt
' was not declared. Should it be static?

The symbol jpeg_dqt is used just in solo6x10-v4l2-enc.c, so I think it
makes sense to declare it static, which suppresses the sparse warning.

Signed-off-by: Sami Laine <laine.j.sami@...il.com>
---
diff --git a/drivers/staging/media/solo6x10/solo6x10-jpeg.h b/drivers/staging/me
index c5218ce..9e41185 100644
--- a/drivers/staging/media/solo6x10/solo6x10-jpeg.h
+++ b/drivers/staging/media/solo6x10/solo6x10-jpeg.h
@@ -110,7 +110,7 @@ static const unsigned char jpeg_header[] = {
 /* This is the byte marker for the start of the DQT */
 #define DQT_START      17
 #define DQT_LEN                138
-const unsigned char jpeg_dqt[4][DQT_LEN] = {
+static const unsigned char jpeg_dqt[4][DQT_LEN] = {
        {
                0xff, 0xdb, 0x00, 0x43, 0x00,
                0x08, 0x06, 0x06, 0x07, 0x06, 0x05, 0x08, 0x07,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/