linux-kernel - Re: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140701070720.GP14257@pengutronix.de>
Date:	Tue, 1 Jul 2014 09:07:20 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] pinctrl: pinctrl-imx27.c:  Cleaning up remove a struct
 that is unused

On Sat, Jun 28, 2014 at 11:48:40PM +0200, Rickard Strandqvist wrote:
> Removal of a struct that is never used
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

It wasn't even used on the initial commit introducing it.

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

> ---
>  drivers/pinctrl/pinctrl-imx27.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-imx27.c b/drivers/pinctrl/pinctrl-imx27.c
> index 417c992..27ae7ce 100644
> --- a/drivers/pinctrl/pinctrl-imx27.c
> +++ b/drivers/pinctrl/pinctrl-imx27.c
> @@ -440,12 +440,6 @@ static struct of_device_id imx27_pinctrl_of_match[] = {
>  	{ /* sentinel */ }
>  };
>  
> -struct imx27_pinctrl_private {
> -	int num_gpio_childs;
> -	struct platform_device **gpio_dev;
> -	struct mxc_gpio_platform_data *gpio_pdata;
> -};
> -
>  static int imx27_pinctrl_probe(struct platform_device *pdev)
>  {
>  	return imx1_pinctrl_core_probe(pdev, &imx27_pinctrl_info);
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/