linux-kernel - Re: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjvbrhsgti.fsf@ultrasam.lan.trained-monkey.org>
Date:	Tue, 01 Jul 2014 09:01:45 +0200
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org,
	Larry Finger <Larry.Finger@...inger.net>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree

Fabian Frederick <fabf@...net.be> writes:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Larry Finger <Larry.Finger@...inger.net>
> Cc: Jes Sorensen <Jes.Sorensen@...hat.com>
> Cc: linux-wireless@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index c8700b3..8714ae3 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter)
>  		pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen;
>  	}
>  
> -	if (pbackup_remainder_ie)
> -		kfree(pbackup_remainder_ie);
> +	kfree(pbackup_remainder_ie);
>  }
>  
>  static void update_bcn_p2p_ie(struct rtw_adapter *padapter)

This one is no longer an issue due to other changes in my tree.

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/