linux-kernel - Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140701093149.7bc71ff5@lxbuild.skidata.net>
Date:	Tue, 1 Jul 2014 09:31:49 +0200
From:	Richard Leitner <richard.leitner@...data.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	David Laight <David.Laight@...LAB.COM>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with
 PREFIX

On Mon, 30 Jun 2014 07:45:43 -0700
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> > > > > From: Of Richard Leitner
> > > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro.
> > > > > > Due to the fact the strings are spread over different source files the
> > > > > > PREFIX definition is moved to u_serial.h
> > > > >
> > > > > Lots of changes like:
> > > > > > -		DBG(cdev, "acm ttyGS%d completion, err %d\n",
> > > > > > -				acm->port_num, req->status);
> > > > > > +		DBG(cdev, "acm %s%d completion, err %d\n",
> > > > > > +				PREFIX, acm->port_num, req->status);
> > > > >
> 
> Use the "proper" debug macros that the kernel provides you (i.e.
> dev_dbg() and family) and then you don't need to put the string in there
> at all, the kernel will do it automatically for you, in the correct
> format, so that all userspace tools can properly track what is going on.
> 
> So please remove the horrid DBG() macro entirely.
> 

It may be a clumsy question, but where do I get the device struct for the ttyGS from? (acm->port.ioport->port_tty ?!?)
The one for the USB gadget is cdev->gadget->dev if I've seen it correctly?

Thank you for your help!

regards,
richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/