linux-kernel - Re: [PATCH resend v2 0/3] mfd-core: Don't register supplies from add_device, add register_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Jul 2014 10:05:24 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Mark Brown <broonie@...aro.org>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Carlo Caione <carlo@...one.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-sunxi@...glegroups.com
Subject: Re: [PATCH resend v2 0/3]  mfd-core: Don't register supplies from
 add_device, add register_supply_aliases()

> I already send this series before (in time for 3.16) and AFAIK we agreed
> on going with this series instead of the incomplete fix for the related oops
> which now has been merged as commit d137be00ee017bc40e6027cb66d667a2e0b450fd
> 
> I still believe that this series is the more correct fix, as platform
> devices must simply not be used at all before they have been added.

We were waiting for Mark's comments.  Which we still have to do.

As they never appeared the temporary fix went in instead.

Moving forward, should that fix be reverted, or it is okay just to
apply this set on top?

> This series changes the probe messages for the axp209 pmic regulators from:
> 
> [    1.386371] Adding alias for supply acin,(null) -> acin,0-0034
> [    1.392205] Adding alias for supply vin2,(null) -> vin2,0-0034
> [    1.398112] Adding alias for supply vin3,(null) -> vin3,0-0034
> [    1.403995] Adding alias for supply ldo24in,(null) -> ldo24in,0-0034
> [    1.410344] Adding alias for supply ldo3in,(null) -> ldo3in,0-0034
> [    1.416551] Adding alias for supply ldo5in,(null) -> ldo5in,0-0034
> 
> To:
> 
> [    1.410545] Adding alias for supply acin,axp20x-regulator -> acin,0-0034
> [    1.417288] Adding alias for supply vin2,axp20x-regulator -> vin2,0-0034
> [    1.424002] Adding alias for supply vin3,axp20x-regulator -> vin3,0-0034
> [    1.430695] Adding alias for supply ldo24in,axp20x-regulator -> ldo24in,0-003
> 4
> [    1.437922] Adding alias for supply ldo3in,axp20x-regulator -> ldo3in,0-0034
> [    1.444973] Adding alias for supply ldo5in,axp20x-regulator -> ldo5in,0-0034
> 
> Notice how all the "(null)" bits are gone.
> 
> No need to rush this into 3.16, but I would still like to see this merged
> into 3.17 .
> 
> Changes since v1:
> -Rebased on top of 3.16-rc1 / commit d137be00ee017bc40e6027cb66d667a2e0b450fd
> 
> Thanks & Regards,
> 
> Hans

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/