lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Jul 2014 15:29:21 +0530 From: Kishon Vijay Abraham I <kishon@...com> To: Kamil Debski <k.debski@...sung.com>, <linux-kernel@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>, <linux-usb@...r.kernel.org> CC: <t.figa@...sung.com>, <m.szyprowski@...sung.com>, <gautam.vivek@...sung.com> Subject: Re: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence Hi Kamil, On Tuesday 24 June 2014 06:24 PM, Kamil Debski wrote: > The Exynos4412 USB 2.0 PHY hardware differs from the description provided > in the documentation. Some register bits have different function. This > patch fixes the defines of register bits and changes the way how phys are > powered on and off. > > Signed-off-by: Kamil Debski <k.debski@...sung.com> Can you fix these checkpatch warnings? WARNING: space prohibited before semicolon #149: FILE: drivers/phy/phy-exynos4x12-usb2.c:227: + EXYNOS_4x12_URSTCON_HOST_LINK_P1 ; WARNING: line over 80 characters #200: FILE: drivers/phy/phy-exynos4x12-usb2.c:278: + exynos4x12_power_on_internal(&drv->instances[EXYNOS4x12_DEVICE]); WARNING: line over 80 characters #210: FILE: drivers/phy/phy-exynos4x12-usb2.c:288: + exynos4x12_power_on_internal(&drv->instances[EXYNOS4x12_DEVICE]); WARNING: line over 80 characters #220: FILE: drivers/phy/phy-exynos4x12-usb2.c:297: +static void exynos4x12_power_off_internal(struct samsung_usb2_phy_instance *inst) WARNING: line over 80 characters #249: FILE: drivers/phy/phy-exynos4x12-usb2.c:319: + exynos4x12_power_off_internal(&drv->instances[EXYNOS4x12_DEVICE]); WARNING: line over 80 characters #253: FILE: drivers/phy/phy-exynos4x12-usb2.c:323: + exynos4x12_power_off_internal(&drv->instances[EXYNOS4x12_DEVICE]); total: 0 errors, 6 warnings, 182 lines checked Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists