linux-kernel - Re: [PATCH] kbuild, LLVMLinux: only use warnings when using clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140701101214.GA14882@pd.tnic>
Date:	Tue, 1 Jul 2014 12:12:14 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	behanw@...verseincode.com
Cc:	mmarek@...e.cz, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, dl9pf@....de, pageexec@...email.hu,
	mcharleb@...il.com
Subject: Re: [PATCH] kbuild, LLVMLinux: only use warnings when using clang

On Mon, Jun 30, 2014 at 05:42:26PM -0700, behanw@...verseincode.com wrote:
> From: Behan Webster <behanw@...verseincode.com>
> 
> Only consider clang warnings in Kbuild when using the clang compiler.
> 
> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> ---
>  scripts/Makefile.extrawarn | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 6564350..e350127 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -26,7 +26,7 @@ warning-1 += $(call cc-option, -Wmissing-include-dirs)
>  warning-1 += $(call cc-option, -Wunused-but-set-variable)
>  warning-1 += $(call cc-disable-warning, missing-field-initializers)
>  
> -# Clang
> +ifeq ($(COMPILER),clang)
>  warning-1 += $(call cc-disable-warning, initializer-overrides)
>  warning-1 += $(call cc-disable-warning, unused-value)
>  warning-1 += $(call cc-disable-warning, format)
> @@ -35,6 +35,7 @@ warning-1 += $(call cc-disable-warning, sign-compare)
>  warning-1 += $(call cc-disable-warning, format-zero-length)
>  warning-1 += $(call cc-disable-warning, uninitialized)
>  warning-1 += $(call cc-option, -fcatch-undefined-behavior)
> +endif

Ok, just to make sure I understand that whole use case correctly:

The disabling of those warnings is really intended for the case where
people build the kernel with "W=1" on the make cmdline *and* clang?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/