linux-kernel - Re: [PATCH] [sched] Don't account time after deadline twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140701155915.55de01236e0540e1f0754560@gmail.com>
Date:	Tue, 1 Jul 2014 15:59:15 +0200
From:	Juri Lelli <juri.lelli@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Zhihui Zhang <zzhsuny@...il.com>, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [sched] Don't account time after deadline twice

On Tue, 1 Jul 2014 15:08:16 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Sun, Jun 29, 2014 at 09:26:10PM -0400, Zhihui Zhang wrote:
> > Unless we want to double-penalize an overrun task, the time after the deadline
> > and before the current time is already accounted in the negative dl_se->runtime
> > value. So we can leave it as is in the case of dmiss && rorun.
> 
> Juri?
> 
> > Signed-off-by: Zhihui Zhang <zzhsuny@...il.com>
> > ---
> >  kernel/sched/deadline.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index fc4f98b1..67df0d6 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -579,10 +579,8 @@ int dl_runtime_exceeded(struct rq *rq, struct sched_dl_entity *dl_se)
> >  	 * the next instance. Thus, if we do not account that, we are
> >  	 * stealing bandwidth from the system at each deadline miss!
> >  	 */
> > -	if (dmiss) {
> > -		dl_se->runtime = rorun ? dl_se->runtime : 0;

If we didn't return 0 before, we are going to throttle (or replenish)
the entity, and you want runtime to be <=0. So, this is needed. 

> > -		dl_se->runtime -= rq_clock(rq) - dl_se->deadline;
> > -	}

A little pessimism in some cases, due to the fact that we use both
rq_clock and rq_clock_task (for the budget).

Thanks,

- Juri

> > +	if (dmiss && !rorun)
> > +		dl_se->runtime = dl_se->deadline - rq_clock(rq);
> >  
> >  	return 1;
> >  }
> > -- 
> > 1.8.1.2
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/