[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140701140226.GJ27971@lee--X1>
Date: Tue, 1 Jul 2014 15:02:26 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Chanwoo Choi <cw00.choi@...sung.com>
Cc: sbkim73@...sung.com, sameo@...ux.intel.com, broonie@...nel.org,
myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
linux-kernel@...r.kernel.org,
Jonghwa Lee <jonghwa3.lee@...sung.com>
Subject: Re: [PATCHv8 2/4] regulator: s2mps11: Add support S2MPU02 regulator
device
On Wed, 25 Jun 2014, Chanwoo Choi wrote:
> This patch add S2MPU02 regulator device to existing S2MPS11 device driver
> because of little difference between S2MPS1x and S2MPU02. The S2MPU02
> regulator device includes LDO[1-28] and BUCK[1-7].
>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> [Add missing linear_min_sel of S2MPU02 LDO regulators by Jonghwa Lee]
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Acked-by: Mark Brown <broonie@...aro.org>
> Acked-by: Lee Jones <lee.jones@...aro.org>
> ---
> drivers/mfd/sec-core.c | 25 ++++
> drivers/regulator/s2mps11.c | 321 +++++++++++++++++++++++++++++++++++++++++--
Why are these change munged into one patch? Shouldn't the MFD changes
really be in patch 1?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists