lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Jul 2014 09:54:24 +0800 From: Zhang Rui <rui.zhang@...el.com> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: Eduardo Valentin <eduardo.valentin@...com>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Cleaning up wrong address is checked On Mon, 2014-06-02 at 23:25 +0200, Rickard Strandqvist wrote: > Wrong address is checked after memory allocation. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> applied, thanks. -rui > --- > drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > index 3ab12ee..43c0f83 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > @@ -1155,7 +1155,7 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev) > /* register shadow for context save and restore */ > bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) * > bgp->conf->sensor_count, GFP_KERNEL); > - if (!bgp) { > + if (!bgp->regval) { > dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n"); > return ERR_PTR(-ENOMEM); > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists