linux-kernel - Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1781051691.1348978.1404234992108.JavaMail.zimbra@redhat.com>
Date:	Tue, 1 Jul 2014 13:16:32 -0400 (EDT)
From:	Bob Peterson <rpeterso@...hat.com>
To:	David Teigland <teigland@...hat.com>
Cc:	Jeff Layton <jlayton@...chiereds.net>, cluster-devel@...hat.com,
	linux-nfs@...r.kernel.org,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	linux-kernel@...r.kernel.org,
	"J. Bruce Fields" <bfields@...ldses.org>,
	linux-fsdevel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from
	lm_grant

----- Original Message -----
> On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote:
> > On Tue, 01 Jul 2014 06:20:10 -0700
> > Joe Perches <joe@...ches.com> wrote:
> > 
> > > While doing a bit of adding argument names to fs.h,
> > > I looked at lm_grant and it seems the 2nd argument
> > > is always NULL.
> > > 
> > > How about removing it?
> > > 
> > > This doesn't apply as it depends on some other patches
> > > but it should be clear enough...
> > > 
> > 
> > ACK on the general idea from my standpoint. Anything that simplifies
> > the file locking interfaces is a good thing, particularly the deferred
> > locking code.
> 
> Fine with me.  I'd be happy to remove all the deferred locking code from
> dlm; it never really worked.
> 
> Dave

Hi,

GFS2 uses deferred locks, at the very least in its direct_io path
(gfs2_direct_IO in aops.c). So AFAIK we can't remove THAT without a certain
amount of pain. Steve is on vacation / holiday this week, but he will
be back on Thursday and Friday (which is a holiday).

I'm all for getting rid of useless parameters, and I've done so on
several occasions in GFS2.

Regards,

Bob Peterson
Red Hat File Systems
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/